[ 
https://issues.apache.org/jira/browse/HUDI-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vinoyang updated HUDI-2410:
---------------------------
    Description: 
 
{code:java}
public static String getDefaultBootstrapIndexClass(Properties props) {
 String defaultClass = BOOTSTRAP_INDEX_CLASS_NAME.defaultValue();
 if 
("false".equalsIgnoreCase(props.getProperty(BOOTSTRAP_INDEX_ENABLE.key()))){ 
    defaultClass = NO_OP_BOOTSTRAP_INDEX_CLASS; 
  }
  return defaultClass;
 }
{code}
 

When hoodie.bootstrap.index.enable is not passed, the original logic will 
follow HFileBootstrapIndex,

This should not be judged here

  was:
public static String getDefaultBootstrapIndexClass(Properties props) {
 String defaultClass = BOOTSTRAP_INDEX_CLASS_NAME.defaultValue();
 if ("false".equalsIgnoreCase(props.getProperty(BOOTSTRAP_INDEX_ENABLE.key())))

{ defaultClass = NO_OP_BOOTSTRAP_INDEX_CLASS; }

return defaultClass;
 }

When hoodie.bootstrap.index.enable is not passed, the original logic will 
follow HFileBootstrapIndex,

This should not be judged here


> Fix getDefaultBootstrapIndexClass logical error
> -----------------------------------------------
>
>                 Key: HUDI-2410
>                 URL: https://issues.apache.org/jira/browse/HUDI-2410
>             Project: Apache Hudi
>          Issue Type: Bug
>          Components: bootstrap
>            Reporter: liujinhui
>            Assignee: liujinhui
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
>  
> {code:java}
> public static String getDefaultBootstrapIndexClass(Properties props) {
>  String defaultClass = BOOTSTRAP_INDEX_CLASS_NAME.defaultValue();
>  if 
> ("false".equalsIgnoreCase(props.getProperty(BOOTSTRAP_INDEX_ENABLE.key()))){ 
>     defaultClass = NO_OP_BOOTSTRAP_INDEX_CLASS; 
>   }
>   return defaultClass;
>  }
> {code}
>  
> When hoodie.bootstrap.index.enable is not passed, the original logic will 
> follow HFileBootstrapIndex,
> This should not be judged here



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to