pratyakshsharma commented on a change in pull request #3653:
URL: https://github.com/apache/hudi/pull/3653#discussion_r707414063
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -386,12 +386,12 @@ object DataSourceWriteOptions {
val HIVE_PARTITION_FIELDS: ConfigProperty[String] = ConfigProperty
.key("hoodie.datasource.hive_sync.partition_fields")
.defaultValue("")
- .withDocumentation("field in the table to use for determining hive
partition columns.")
+ .withDocumentation("Field in the table to use for determining hive
partition columns.")
val HIVE_PARTITION_EXTRACTOR_CLASS: ConfigProperty[String] = ConfigProperty
.key("hoodie.datasource.hive_sync.partition_extractor_class")
.defaultValue(classOf[SlashEncodedDayPartitionValueExtractor].getCanonicalName)
- .withDocumentation("")
+ .withDocumentation("Class which implements PartitionValueExtractor to
extract the partition values.")
Review comment:
Can we give a small example also here?
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -401,7 +401,9 @@ object DataSourceWriteOptions {
val HIVE_USE_PRE_APACHE_INPUT_FORMAT: ConfigProperty[String] = ConfigProperty
.key("hoodie.datasource.hive_sync.use_pre_apache_input_format")
.defaultValue("false")
- .withDocumentation("")
+ .withDocumentation("Use InputFormat under com.uber.hoodie package instead
of org.apache.hudi package. "
Review comment:
Use InputFormat -> Flag to choose InputFormat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
