leesf commented on a change in pull request #3668:
URL: https://github.com/apache/hudi/pull/3668#discussion_r709163345
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -1068,4 +1076,150 @@ public void close() {
this.heartbeatClient.stop();
this.txnManager.close();
}
+
+ /**
+ * add columns to table.
+ *
+ * @param colName col name to be added. if we want to add col to a nested
filed, the fullName should be specify
+ * @param schema col type to be added.
+ * @param doc col doc to be added.
+ * @param position col position to be added
+ * @param positionType col position change type. now support three change
types: first/after/before
+ */
+ public void addColumns(String colName, Schema schema, String doc, String
position, String positionType) {
+ Pair<InternalSchema, HoodieTableMetaClient> pair =
getInternalSchemaAndMetaClient();
+ TableChanges.ColumnAddChange add =
TableChanges.ColumnAddChange.get(pair.getLeft());
+ String parentName = TableChanges.getParentName(colName);
+ add.addColumns(parentName, colName, AvroSchemaUtil.convertToField(schema),
doc);
+ if (position != null && !position.isEmpty() && positionType != null &&
!position.isEmpty()) {
Review comment:
the last `!position.isEmpty()` change to `!positionType.isEmpty()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
