xiarixiaoyao commented on pull request #3330: URL: https://github.com/apache/hudi/pull/3330#issuecomment-921614646
@vinothchandar thanks for your review。 update the code. 1. Merge HoodieOptimizeConfig to HoodieClusteringConfig. Add more docs for parameter 2. fix all comments. 3. deal with the scenario that handling of failed, retried cluster operations at the same instant time. before we save statistics info into indexTable，all residual files will be delete，include the files which produced by retried. 4. this pr only use the unsafe compare method from hbase. no code from other project, as i know, only impala in the open source implements zorder in C++/ the unsafe Lexicographically comparison algorithm in hbase is faster then jave implement。 If you think the unsafe method should not be used, I can provide a java implementation。 One last thing： This pr actually implements two functions, one is zorder and the other is dataskipping。 For better review, maybe we can split this pr into two prs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
