danny0405 commented on a change in pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#discussion_r718092117
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -486,8 +486,8 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> CLEAN_ASYNC_ENABLED = ConfigOptions
.key("clean.async.enabled")
.booleanType()
- .defaultValue(true)
- .withDescription("Whether to cleanup the old commits immediately on new
commits, enabled by default");
+ .defaultValue(false)
+ .withDescription("Whether to cleanup the old commits immediately on new
commits, disabled by default");
Review comment:
We should keep it true, the cleaning logic also works for COW table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
