zhangyue19921010 commented on a change in pull request #3719:
URL: https://github.com/apache/hudi/pull/3719#discussion_r718207481
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -202,10 +212,6 @@ public boolean accept(Path path) {
}
nonHoodiePathCache.add(folder.toString());
return true;
- } finally {
- if (fsView != null) {
- fsView.close();
- }
Review comment:
`fsView.close()` will do
```
@Override
public void close() {
closed = true;
super.reset();
partitionToFileGroupsMap = null;
fgIdToPendingCompaction = null;
fgIdToBootstrapBaseFile = null;
fgIdToReplaceInstants = null;
}
because of we recycling fsView, we can't close it. Although we create fsView
for each baseDir. And will cause no memory leak maybe.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
