xushiyan commented on a change in pull request #3413:
URL: https://github.com/apache/hudi/pull/3413#discussion_r718245885
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
##########
@@ -129,10 +129,12 @@
public static final Schema AVRO_SCHEMA = new
Schema.Parser().parse(TRIP_EXAMPLE_SCHEMA);
+ public static final Schema ORC_SCHEMA = new
Schema.Parser().parse(TRIP_EXAMPLE_SCHEMA);
Review comment:
ditto
```suggestion
public static final TypeDescription ORC_SCHEMA =
AvroOrcUtils.createOrcSchema(new Schema.Parser().parse(TRIP_EXAMPLE_SCHEMA));
```
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
##########
@@ -129,10 +129,12 @@
public static final Schema AVRO_SCHEMA = new
Schema.Parser().parse(TRIP_EXAMPLE_SCHEMA);
+ public static final Schema ORC_SCHEMA = new
Schema.Parser().parse(TRIP_EXAMPLE_SCHEMA);
public static final Schema AVRO_SCHEMA_WITH_METADATA_FIELDS =
HoodieAvroUtils.addMetadataFields(AVRO_SCHEMA);
public static final Schema AVRO_SHORT_TRIP_SCHEMA = new
Schema.Parser().parse(SHORT_TRIP_SCHEMA);
public static final Schema AVRO_TRIP_SCHEMA = new
Schema.Parser().parse(TRIP_SCHEMA);
+ public static final Schema ORC_TRIP_SCHEMA = new
Schema.Parser().parse(TRIP_SCHEMA);
Review comment:
@zhangyue19921010 I think I wasn't clear about the suggestion. What i
meant is, here in HoodieTestDataGenerator,
```suggestion
public static final TypeDescription ORC_TRIP_SCHEMA =
AvroOrcUtils.createOrcSchema(new Schema.Parser().parse(TRIP_SCHEMA));
```
This constant is named as `ORC_XXX_SCHEMA` but its type still an avro
schema, causing confusion. That's why i suggest do conversion here, and make
the constant less confusing and easier to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
