yihua commented on a change in pull request #3727:
URL: https://github.com/apache/hudi/pull/3727#discussion_r719756887



##########
File path: 
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -321,15 +324,14 @@ protected void completeCompaction(HoodieCommitMetadata 
metadata, JavaRDD<WriteSt
   protected JavaRDD<WriteStatus> compact(String compactionInstantTime, boolean 
shouldComplete) {
     HoodieSparkTable<T> table = HoodieSparkTable.create(config, context);
     preWrite(compactionInstantTime, WriteOperationType.COMPACT, 
table.getMetaClient());
-    HoodieTimeline pendingCompactionTimeline = 
table.getActiveTimeline().filterPendingCompactionTimeline();
-    HoodieInstant inflightInstant = 
HoodieTimeline.getCompactionInflightInstant(compactionInstantTime);
-    if (pendingCompactionTimeline.containsInstant(inflightInstant)) {
-      rollbackInflightCompaction(inflightInstant, table);
-      table.getMetaClient().reloadActiveTimeline();
-    }
     compactionTimer = metrics.getCompactionCtx();
-    HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata = 
table.compact(context, compactionInstantTime);
-    JavaRDD<WriteStatus> statuses = compactionMetadata.getWriteStatuses();
+    HoodieSparkCopyOnWriteTable sparkCopyOnWriteTable =
+        new HoodieSparkCopyOnWriteTable(config, context, 
table.getMetaClient());
+    HoodieWriteMetadata<HoodieData<WriteStatus>> compactionMetadata =
+        CompactHelpers.newInstance().compact(context, table, 
sparkCopyOnWriteTable,
+            config, compactionInstantTime, this, new 
SparkTaskContextSupplier());

Review comment:
       Right. Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to