helanto commented on a change in pull request #3740:
URL: https://github.com/apache/hudi/pull/3740#discussion_r720090162
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieConcatHandle.java
##########
@@ -94,4 +107,34 @@ public void write(GenericRecord oldRecord) {
}
recordsWritten++;
}
+
+ boolean needsUpdateLocation() {
Review comment:
It is because it has `package-private` access modifier;
`HoodieMergeHandle` and `HoodieConcatHandle` are in different package. I can
either move to the same package, or change the access modifier to `protected`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
