yihua commented on a change in pull request #3741:
URL: https://github.com/apache/hudi/pull/3741#discussion_r726803858
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -366,12 +367,13 @@ public HoodieActiveTimeline getActiveTimeline() {
/**
* Run Compaction on the table. Compaction arranges the data so that it is
optimized for data access.
*
- * @param context HoodieEngineContext
+ * @param context HoodieEngineContext
* @param compactionInstantTime Instant Time
+ * @param writeClient Write client
*/
public abstract HoodieWriteMetadata<O> compact(HoodieEngineContext context,
- String compactionInstantTime);
-
+ String compactionInstantTime,
+ AbstractHoodieWriteClient
writeClient);
Review comment:
Yes, somehow `writeClient` is needed here for rollback logic, and I
agree it does not look neat. When I refactor this part I didn't see an easy
way to get rid of this pattern. I'll take another look to see if this can be
avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
