danny0405 commented on a change in pull request #3741:
URL: https://github.com/apache/hudi/pull/3741#discussion_r728594783
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -383,7 +388,13 @@ public void completeCompaction(
protected List<WriteStatus> compact(String compactionInstantTime, boolean
shouldComplete) {
// only used for metadata table, the compaction happens in single thread
try {
- List<WriteStatus> writeStatuses =
FlinkCompactHelpers.compact(compactionInstantTime, this);
+ RunCompactionActionExecutor compactionExecutor = new
RunCompactionActionExecutor(
+ context, config, getHoodieTable(), compactionInstantTime, this,
Review comment:
A better way is moving the `new RunCompactionActionExecutor` execution
into the `HoodieFlinkTable` impl `#compact`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
