vinothchandar commented on a change in pull request #3486:
URL: https://github.com/apache/hudi/pull/3486#discussion_r730112564
##########
File path: hudi-client/hudi-client-common/pom.xml
##########
@@ -218,6 +222,27 @@
<version>${zk-curator.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.amazonaws</groupId>
Review comment:
instead of having this dependency in `hudi-client-common`, can we have
this in a `hudi-aws` module, which gets bundled with spark and utilities
bundles?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java
##########
@@ -164,6 +171,52 @@
.withDocumentation("Key name under base_path at which to create a ZNode
and acquire lock. "
+ "Final path on zk will look like base_path/lock_key. We recommend
setting this to the table name");
+ public static final ConfigProperty<String> DYNAMODB_TABLE_NAME =
ConfigProperty
Review comment:
Configs could remain here or move out as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
