vinothchandar commented on a change in pull request #3824:
URL: https://github.com/apache/hudi/pull/3824#discussion_r732046608
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -59,7 +59,7 @@
*/
public class HoodieActiveTimeline extends HoodieDefaultTimeline {
- public static final SimpleDateFormat COMMIT_FORMATTER = new
SimpleDateFormat("yyyyMMddHHmmss");
+ public static final SimpleDateFormat COMMIT_FORMATTER = new
SimpleDateFormat("yyyyMMddHHmmssSSS");
Review comment:
IIRC there is just one place where we assume something about the time
format. its for scheduling compactions every N minutes i.e by elapsed time
since last compaction. Might want to check that.
Other thing to consider, is how this formatter parses existing
`yyyyMMddHHmmss` events in timeline? Also worth checking out are different
constants in bootstrap and metadata table code, that denote t0 or start of
time.
cc @nsivabalan can you please research these and help @davehagman along the
way. lmk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
