nsivabalan commented on a change in pull request #3762:
URL: https://github.com/apache/hudi/pull/3762#discussion_r733024714
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
##########
@@ -342,17 +377,17 @@ private void processDataBlock(HoodieDataBlock dataBlock)
throws Exception {
/**
* Process the set of log blocks belonging to the last instant which is read
fully.
*/
- private void processQueuedBlocksForInstant(Deque<HoodieLogBlock> lastBlocks,
int numLogFilesSeen) throws Exception {
- while (!lastBlocks.isEmpty()) {
- LOG.info("Number of remaining logblocks to merge " + lastBlocks.size());
+ private void processQueuedBlocksForInstant(Deque<HoodieLogBlock> logBlocks,
int numLogFilesSeen, List<String> keys) throws Exception {
Review comment:
yeah, I don't want to pass them during logBlock instantiation. and hence
had to do it this way. if you can think of better ways, let.me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
