davehagman commented on pull request #3824: URL: https://github.com/apache/hudi/pull/3824#issuecomment-947960080
> we don't upgrade them every to new format right. Just that the newer ones we generated are in new format. One potential issue I see is that if you have an old instant without millis such as `20210101120101` and you then parse that to a date (by calling `parseDateFromInstantTime`), and back to an instant ID you will now have `20210101120101000` (millis attached). If for some reason we try to lookup a specific instant based purely on a `Date` instance then it will not be found (since the actual persisted instant does not have the `000` appended). I am trying to find examples of that happening in the codebase but if you know of something then I can focus on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
