dongkelun commented on a change in pull request #3746:
URL: https://github.com/apache/hudi/pull/3746#discussion_r734925672
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetReaderIterator.java
##########
@@ -59,6 +59,6 @@ public void testParquetIterator() throws IOException {
assertEquals(1, iterator.next());
// no more entries to iterate on
assertFalse(iterator.hasNext());
- assertThrows(HoodieIOException.class, iterator::next, "should throw an
exception since there is only 1 record");
+ assertThrows(HoodieException.class, iterator::next, "should throw an
exception since there is only 1 record");
Review comment:
@yihua Hello, use the `verify ` method to verify whether the `close`
method is called?
First, the HoodieIOExceptionis thrown, then caught, and then the
HoodieException is thrown, so it can fix the unit test failure. But for code
unification, I also changed the HoodieIOExceptionis to HoodieException . Do you
think this is OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
