nsivabalan commented on a change in pull request #3762:
URL: https://github.com/apache/hudi/pull/3762#discussion_r735268438
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
##########
@@ -120,65 +120,114 @@ private void initIfNeeded() {
}
@Override
- protected Option<HoodieRecord<HoodieMetadataPayload>>
getRecordByKeyFromMetadata(String key, String partitionName) {
- Pair<HoodieFileReader, HoodieMetadataMergedLogRecordScanner> readers =
openReadersIfNeeded(key, partitionName);
+ protected Option<HoodieRecord<HoodieMetadataPayload>> getRecordByKey(String
key, String partitionName) {
+ return getRecordsByKeys(Collections.singletonList(key),
partitionName).get(0).getValue();
+ }
+
+ protected List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>>
getRecordsByKeys(List<String> keys, String partitionName) {
Review comment:
1. I see your point regarding inline/full scan to be configurable
depending on diff partitions in metadata. I will address this. I guess, FILES
will do full scan. while col_stats(min max stats), bloom_filter and record
index will do inline.
2. If we go with (1), not sure if we need to try out (2) as well. with (1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
