codope commented on a change in pull request #3802:
URL: https://github.com/apache/hudi/pull/3802#discussion_r736347663
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1137,8 +1144,9 @@ public void testHoodieAsyncClusteringJob() throws
Exception {
});
}
- @Test
- public void testAsyncClusteringService() throws Exception {
+ @ParameterizedTest
+ @ValueSource(strings = {"true", "false"})
+ public void testAsyncClusteringService(String preserveCommitMetadata) throws
Exception {
Review comment:
Since async creates another thread, i think it's better to test both
inline and async clustering in general. Is your concern around test time? I can
undo parameterized test for `testAsyncClusteringService` and keep it only for
`testAsyncClusteringServiceWithCompaction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
