leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736660076
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java
##########
@@ -259,7 +268,7 @@ public void testNoRecordKeyFieldProp(boolean
useKeyGeneratorClassName) {
.getMessage()
.contains("Property hoodie.datasource.write.recordkey.field not
found"));
} else {
- Assertions.assertTrue(e.getMessage().contains("Property
hoodie.datasource.write.recordkey.field not found"));
Review comment:
why need the change here?
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java
##########
@@ -282,7 +291,7 @@ public void testNoRecordKeyFieldProp(boolean
useKeyGeneratorClassName) {
.getMessage()
.contains("Property hoodie.datasource.write.recordkey.field not
found"));
} else {
- Assertions.assertTrue(e.getMessage().contains("Property
hoodie.datasource.write.recordkey.field not found"));
+ Assertions.assertTrue(stackTraceToString(e).contains("Property
hoodie.datasource.write.recordkey.field not found"));
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
