codope commented on a change in pull request #3833:
URL: https://github.com/apache/hudi/pull/3833#discussion_r740179819
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java
##########
@@ -1370,6 +1372,19 @@ public void testClusteringWithSortColumns(boolean
populateMetaFields, boolean pr
testInsertAndClustering(clusteringConfig, populateMetaFields, true,
SqlQueryEqualityPreCommitValidator.class.getName(),
COUNT_SQL_QUERY_FOR_VALIDATION, "");
}
+ @ParameterizedTest
+ @MethodSource("populateMetaFieldsAndPreserveMetadataParams")
+ public void testClusteringWithSortOneFilePerGroup(boolean
populateMetaFields, boolean preserveCommitMetadata) throws Exception {
+ // setup clustering config.
+ HoodieClusteringConfig clusteringConfig =
HoodieClusteringConfig.newBuilder().withClusteringMaxNumGroups(10)
+ .withClusteringSortColumns("begin_lat,begin_lon")
+
.withClusteringPlanStrategyClass(SparkSingleFileSortPlanStrategy.class.getName())
+
.withClusteringExecutionStrategyClass(SparkSingleFileSortExecutionStrategy.class.getName())
+ .withClusteringTargetPartitions(0).withInlineClusteringNumCommits(1)
+ .withPreserveHoodieCommitMetadata(preserveCommitMetadata).build();
+ testInsertAndClustering(clusteringConfig, populateMetaFields, true,
SqlQueryEqualityPreCommitValidator.class.getName(),
COUNT_SQL_QUERY_FOR_VALIDATION, "");
Review comment:
That's a good point. Though we are getting the clustering group fileIDs
in `performClustering` but not asserting anywhere. I'll add it to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
