nsivabalan commented on a change in pull request #3901:
URL: https://github.com/apache/hudi/pull/3901#discussion_r740539568
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
##########
@@ -199,10 +203,14 @@ private void initIfNeeded() {
}
} else {
// only log record
+ LOG.warn("TEST_LOG. 111 Looking for record " + key + ", isPresent in
log " + logRecords.containsKey(key));
if (logRecords.containsKey(key) && logRecords.get(key).isPresent()) {
+ LOG.warn("TEST_LOG. 222 found log record " + key);
HoodieRecordPayload mergedPayload =
logRecords.get(key).get().getData().preCombine(hoodieRecord.getData());
+ LOG.warn("TEST_LOG. 3333 merged log record " + key);
result.add(Pair.of(key, Option.of(new
HoodieRecord(hoodieRecord.getKey(), mergedPayload))));
} else { // not found in both base file and log files
+ LOG.warn("TEST_LOG. 444 not log record found " + key);
Review comment:
yes, there is some test failure I am looking to triage. could not repro
locally. will revert before landing the patch.
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
##########
@@ -834,6 +834,7 @@ public void testCleaningArchivingAndCompaction() throws
Exception {
.withCompactionConfig(HoodieCompactionConfig.newBuilder().archiveCommitsWith(2,
4)
.withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.NEVER)
.retainCommits(1).retainFileVersions(1).withAutoClean(true).withAsyncClean(false).build())
+ .withEmbeddedTimelineServerEnabled(false)
Review comment:
yes, will revert before landing
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
##########
@@ -165,6 +165,10 @@ private void initIfNeeded() {
logRecords.put(entry.getKey(), entry.getValue());
}
}
+ } else {
Review comment:
a test was failing in CI and so I fixed it in this patch. Did not want
to land this patch with failing CI. I thought of putting up a separate patch,
but the other one will depend on this patch since tests might time out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
