zhedoubushishi commented on a change in pull request #3416:
URL: https://github.com/apache/hudi/pull/3416#discussion_r742508801



##########
File path: 
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala
##########
@@ -94,7 +94,7 @@ case class CreateHoodieTableCommand(table: CatalogTable, 
ignoreIfExists: Boolean
 
      // Get options from the external table and append with the options in ddl.
      val originTableConfig =  HoodieOptionConfig.mappingTableConfigToSqlOption(
-       metaClient.getTableConfig.getProps.asScala.toMap)
+       metaClient.getTableConfig.getProps().asScala.toMap)

Review comment:
       After rethinking about this part, I feel like we should honor the 
configurations load from the external table, so I didn't import the Hudi 
external configuration here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to