xushiyan commented on a change in pull request #3416:
URL: https://github.com/apache/hudi/pull/3416#discussion_r742544034
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -117,7 +137,50 @@ public void addProperties(BufferedReader reader) throws
IOException {
}
}
+ public static TypedProperties getGlobalConfig() {
+ final TypedProperties globalProps = new TypedProperties();
+ globalProps.putAll(HUDI_CONF_PROPS);
+ return globalProps;
+ }
+
public TypedProperties getConfig() {
- return props;
+ return getConfig(false);
+ }
+
+ public TypedProperties getConfig(boolean includeHudiConf) {
Review comment:
ditto
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -117,7 +137,50 @@ public void addProperties(BufferedReader reader) throws
IOException {
}
}
+ public static TypedProperties getGlobalConfig() {
Review comment:
```suggestion
public static TypedProperties getGlobalProps() {
```
minor: "config" a bit vague. "Props" strongly hints it's a Properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
