nsivabalan opened a new pull request #3930:
URL: https://github.com/apache/hudi/pull/3930


   - Adding parquet data block with inline read support.
   - Added a config hoodie.table.log.block.type to determine the log block 
type. If not set, we will fallback to determining log block type based on base 
file format. if set, we will use the config value.
   - Added some minimal tests to ensure adding a parquet data block and reading 
it using AbstractLogRecordScanner works fine.
   
   Pending items:
   - where to store the configs for new parquet data block. we need index 
configs, and parquet write configs too. Don't think we can reuse existing ones 
its purpose is different. Once have consensus, will have to fix the configs for 
the same.
   - Added only inline read support in this patch. Wanted to understand if we 
need to support the older way (read entire content and then deserialize 
records). 
   - Add more end to end tests to test parquet data blocks.
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to