vinothchandar commented on a change in pull request #3486:
URL: https://github.com/apache/hudi/pull/3486#discussion_r743769523
##########
File path: hudi-client/hudi-client-common/pom.xml
##########
@@ -41,6 +41,11 @@
<artifactId>hudi-timeline-service</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
wondering if this is needed here, at all?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java
##########
@@ -35,6 +38,13 @@
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_CONNECTION_TIMEOUT_MS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_SESSION_TIMEOUT_MS;
+import static
org.apache.hudi.common.config.LockConfiguration.DYNAMODB_LOCK_BILLING_MODE_PROP_KEY;
Review comment:
We have the ability to group the configs on docs together i.e
`HoodieLockConfig` + `DynamoDBLockConfig` so if this is the reasons for the
dependency, we can actually move this back to `hoodie-aws`?
##########
File path: packaging/hudi-flink-bundle/pom.xml
##########
@@ -149,6 +150,10 @@
<include>org.apache.hbase:hbase-protocol</include>
<include>org.apache.htrace:htrace-core</include>
<include>commons-codec:commons-codec</include>
+
Review comment:
I think just adding these into the bundles are sufficient, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
