nsivabalan commented on pull request #3820:
URL: https://github.com/apache/hudi/pull/3820#issuecomment-964236722


   @n3nash : After some thinking, here is my take. 
   Old config is used for two purpose. 
   1. Carrying over deltastreamer checkpoint. 
   2. Carrying over any regex (prefix) based extra metadata from previous 
commit to current one. 
   
   And this is used only within multi-writer code path. I don't see this being 
used in single writer. 
   Given we have fixed the (1) above with new config, and multi-writer is an 
evolving feature, I prefer to go ahead w/ new config. We can add the old 
config(`hoodie.write.meta.key.prefixes`) as an alternative to the new one, but 
only (1) will be taken care. We will definitely call this out in release notes. 
   
   If you feel we definitely need support for (2) above, let me know. I fill 
file a follow up ticket and work on it. but I prefer to fix for both single 
writer and multi-writer. not sure why we had a constraint only with 
multiwriter. If you can find resources to work on it, I am good too. Hoping to 
close this out sooner. Let me know.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to