manojpec opened a new pull request #3955:
URL: https://github.com/apache/hudi/pull/3955


   ## What is the purpose of the pull request
   
   Avoid ArithmeticException from ExternalSpillableMap put operations.
   
   ## Brief change log
   
   - ExternalSpillableMap does the payload/value size estimation on the first 
put to
     determine when to spill over to disk map. The payload size re-estimation 
also
     happens after a minimum threshold of puts. This size re-estimation goes my 
the
     current in-memory map size for calculating average payload size and does 
attempts
     divide by zero operation when the map is size is empty. Avoiding the
     ArithmeticException during the payload size re-estimate by checking the 
map size
     upfront.
   
   - Added an unit test to repro the case and exercise the fix.
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to