nsivabalan commented on a change in pull request #3486:
URL: https://github.com/apache/hudi/pull/3486#discussion_r741536160
##########
File path: hudi-client/hudi-client-common/pom.xml
##########
@@ -218,6 +222,27 @@
<version>${zk-curator.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.amazonaws</groupId>
Review comment:
@vinothchandar : I assume you are suggesting to create a new module
hudi-aws and move these over there and so all bundles (spark, utilities, flink
etc) can depend on them and leave client-common as is.
@zhedoubushishi : can you address above feedback please.
##########
File path: hudi-client/hudi-client-common/pom.xml
##########
@@ -41,6 +41,11 @@
<artifactId>hudi-timeline-service</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review comment:
here is what is making this necessary.
We add HoodieAwsconfig in HoodieWriteconfig and hence client-common has to
depend on hudi-aws module. If we can follow something like
kafka-connect-configs, we can keep HoodieAwsConfig separate and not add it to
HoodieWriteConfig, we should be able to get rid of this dep.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java
##########
@@ -35,6 +38,13 @@
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_CONNECTION_TIMEOUT_MS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_SESSION_TIMEOUT_MS;
+import static
org.apache.hudi.common.config.LockConfiguration.DYNAMODB_LOCK_BILLING_MODE_PROP_KEY;
Review comment:
if we go with the approach I suggested above, these configs and
constants will move to hudi-aws module and we can make hudi-aws depend on
hudi-client-common(for the TBL_NAME usage above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
