nsivabalan commented on a change in pull request #3977:
URL: https://github.com/apache/hudi/pull/3977#discussion_r747924768
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFSUtils.java
##########
@@ -54,21 +57,26 @@ public static Path getInlineFilePath(Path outerPath, String
origScheme, long inL
}
/**
- * Inline file format
- *
"inlinefs://<path_to_outer_file>/<outer_file_scheme>/?start_offset=start_offset>&length=<length>"
- * Outer File format
- * "<outer_file_scheme>://<path_to_outer_file>"
+ * InlineFS Path format:
+ *
"inlinefs://path/to/outer/file/outer_file_schema/?start_offset=start_offset>&length=<length>"
* <p>
- * Eg input : "inlinefs://file1/sa3/?start_offset=20&length=40".
- * Output : "sa3://file1"
+ * Outer File Path format:
+ * "outer_file_schema://path/to/outer/file"
+ * <p>
+ * Example
+ * Input: "inlinefs://file1/s3a/?start_offset=20&length=40".
Review comment:
I am thinking if we should encode the no of slashes as well when inline
path is generated and then later re-use when we regenerate the original path
later? so that it works for any schemes.
```
inlinefs://file1/s3a/?start_offset=20&length=40&slashes=2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
