nsivabalan opened a new pull request #3983:
URL: https://github.com/apache/hudi/pull/3983


   ## What is the purpose of the pull request
   
   Restore internally does rollback of N commits in reverse chronological 
order. Since these are completed instants, we have to use list based rollback 
strategy irrespective of what the writeconfig says for rollback strategy. Fixed 
the rollback planning phase to take an explicit argument on this regard and 
honor the same. 
   
   ## Brief change log
   
   - Fixed rollback scheduling/planning to take an explicit argument for the 
rollback strategy to use instead of relying on writeConfig values. 
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests.
   
   - Flipped to rollback based marker strategy in one of the tests which 
involves restore. Without the fix, the test fails and now it succeeds. 
   TestHoodieClientOnCopyOnWriteStorage#testUpserts
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to