[GitHub] [hudi] nsivabalan commented on pull request #3824: [HUDI-2559] Millisecond granularity for instant timestamps

[GitBox]

nsivabalan commented on pull request #3824:
URL: https://github.com/apache/hudi/pull/3824#issuecomment-967777486


   summary of tests I did with this patch. Looks to be good. 
   
   1. Ran test suite yaml for 10 iterations (~50 commits) for both table types 
with inserts, updates and deletes. 
   2. Upgrade testing:
      Created a table with 090. After clustering was scheduled killed the 
deltasreamer. so all commits and replace commit so far are in secs granularity. 
      Used this patch and restarted the deltastreamer. new commits were in ms 
granularity. As expected inflight clustering was rolledback and again attempted 
with same secs granuality. And succeeds too. 
      After few commits, new clustering was seen with ms granularity. 
   
   Attaching screen shots from my local testing. 
   
   
   <img width="1779" alt="Screen Shot 2021-11-12 at 11 05 04 PM" 
src="https://user-images.githubusercontent.com/513218/141605488-6ebf3cd6-7d5f-4ffb-9d11-a6595e2a7bdd.png";>
   <img width="1713" alt="Screen Shot 2021-11-12 at 11 13 50 PM" 
src="https://user-images.githubusercontent.com/513218/141605490-b9188f92-45c7-4cfa-900a-6bb4a249fbb6.png";>
   <img width="1621" alt="Screen Shot 2021-11-12 at 11 15 02 PM" 
src="https://user-images.githubusercontent.com/513218/141605492-9049383b-aebc-447f-863b-6e5be6c05efb.png";>
   
   
      


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org