yihua commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r751531265
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
package org.apache.hudi.common.config;
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
import javax.annotation.concurrent.Immutable;
import java.io.File;
Review comment:
Got it. As discussed, functionality-wise this is fine. Wondering if we
can still set it with `.noDefaultValue()` instead of `.defaultValue(true)`, not
to confuse developers on Java client. I'll let you decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
