satishkotha commented on a change in pull request #3869:
URL: https://github.com/apache/hudi/pull/3869#discussion_r752863022
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
##########
@@ -191,6 +191,14 @@
.sinceVersion("0.10.0")
.withDocumentation("Enable data skipping by collecting statistics once
layout optimization is complete.");
+ public static final ConfigProperty<Boolean> ROLLBACK_PENDING_CLUSTERING =
ConfigProperty
Review comment:
if you strong opinion on keeping conflicts logic, please change config
name and description go say clustering rollback will be done only if there is a
conflict
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
##########
@@ -191,6 +191,14 @@
.sinceVersion("0.10.0")
.withDocumentation("Enable data skipping by collecting statistics once
layout optimization is complete.");
+ public static final ConfigProperty<Boolean> ROLLBACK_PENDING_CLUSTERING =
ConfigProperty
Review comment:
if you have a strong opinion on keeping conflicts logic, please change
config name and description go say clustering rollback will be done only if
there is a conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
