nsivabalan commented on a change in pull request #4039:
URL: https://github.com/apache/hudi/pull/4039#discussion_r753419515
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -362,10 +352,62 @@ public void initTableMetadata() {
return false;
}
+ /**
+ * Is the latest commit instant reverted by the in-flight instant action?
+ *
+ * @param actionMetadata - In-flight instant action metadata
+ * @param latestMetadataInstantTimestamp - Metadata table latest instant
timestamp
+ * @param <T> - ActionMetadata type
+ * @return True if the latest instant action is reverted by the action
+ */
+ private <T extends SpecificRecordBase> boolean
isCommitRevertedByInFlightAction(Option<T> actionMetadata,
+
final String latestMetadataInstantTimestamp) {
+
+ if (!actionMetadata.isPresent()) {
+ return false;
+ }
+
+ final String INSTANT_ACTION = (actionMetadata.get() instanceof
HoodieRollbackMetadata
+ ? HoodieTimeline.ROLLBACK_ACTION
+ : (actionMetadata.get() instanceof HoodieRestoreMetadata ?
HoodieTimeline.RESTORE_ACTION : ""));
+
+ List<String> affectedInstantTimestamps;
+ switch (INSTANT_ACTION) {
+ case HoodieTimeline.ROLLBACK_ACTION:
+ List<HoodieInstantInfo> rollbackedInstants =
+ ((HoodieRollbackMetadata)
actionMetadata.get()).getInstantsRollback();
+ affectedInstantTimestamps = rollbackedInstants.stream().map(instant ->
{
+ return instant.getCommitTime().toString();
+ }).collect(Collectors.toList());
+
+ if
(affectedInstantTimestamps.contains(latestMetadataInstantTimestamp)) {
+ return true;
+ }
+ break;
+
Review comment:
can you remove unnecessary line breaks in this method
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
##########
@@ -871,7 +871,7 @@ public void testReader() throws Exception {
*/
@Test
public void testCleaningArchivingAndCompaction() throws Exception {
- init(HoodieTableType.COPY_ON_WRITE, false);
+ init(HoodieTableType.COPY_ON_WRITE, true);
Review comment:
same here.
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
##########
@@ -361,7 +361,7 @@ public void testRollbackOperations(HoodieTableType
tableType) throws Exception {
@Test
public void testManualRollbacks() throws Exception {
HoodieTableType tableType = COPY_ON_WRITE;
- init(tableType, false);
+ init(tableType, true);
Review comment:
why this change? this test intentionally not enabled at the beginning
and enables at line 377.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
