vinothchandar commented on a change in pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#discussion_r754789346



##########
File path: 
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
##########
@@ -434,6 +434,49 @@ public void 
testUpsertPartitionerWithSmallFileHandlingWithCanIndexLogFiles() thr
             "Insert should be assigned to fg1");
   }
 
+  @Test
+  public void 
testUpsertPartitionerWithSmallFileHandlingPickingMultipleCandidates() throws 
Exception {
+    final String partitionPath = DEFAULT_PARTITION_PATHS[0];
+
+    HoodieWriteConfig config =

Review comment:
       @alexeykudinkin let's keep the code styling more consistent with whats 
there already? 
   
   ```
   HoodieWriteConfig config = makeHoodieClientConfigBuilder()
   ```
   instead of 
   
   ```
   HoodieWriteConfig config =
                   makeHoodieClientConfigBuilder
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to