vinothchandar commented on a change in pull request #3703:
URL: https://github.com/apache/hudi/pull/3703#discussion_r756471788
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -303,8 +303,8 @@ private String getSourceOperatorName(String operatorName) {
}
HoodieTableFileSystemView fsView = new
HoodieTableFileSystemView(metaClient,
- metaClient.getActiveTimeline().getCommitsTimeline()
- .filterCompletedInstants(), fileStatuses);
+ // file-slice after pending compaction-requested instant-time is also
considered valid
+
metaClient.getCommitsAndCompactionTimeline().filterCompletedAndCompactionInstants(),
fileStatuses);
Review comment:
this has the effect of including `compaction.requested` etc in the
timeline passed to the fs view
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -303,8 +303,8 @@ private String getSourceOperatorName(String operatorName) {
}
HoodieTableFileSystemView fsView = new
HoodieTableFileSystemView(metaClient,
- metaClient.getActiveTimeline().getCommitsTimeline()
- .filterCompletedInstants(), fileStatuses);
+ // file-slice after pending compaction-requested instant-time is also
considered valid
+
metaClient.getCommitsAndCompactionTimeline().filterCompletedAndCompactionInstants(),
fileStatuses);
Review comment:
`getCommitsAndCompactionTimeline()` is really
`getCommitsOrCompactionTimeline()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
