vinothchandar commented on a change in pull request #4112:
URL: https://github.com/apache/hudi/pull/4112#discussion_r757131090
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java
##########
@@ -312,9 +322,17 @@ protected HoodieWriteConfig getConfig(Boolean autoCommit,
Boolean rollbackUsingM
.withStorageConfig(HoodieStorageConfig.newBuilder().hfileMaxFileSize(1024 *
1024 * 1024).parquetMaxFileSize(1024 * 1024 * 1024).build())
.withEmbeddedTimelineServerEnabled(true).forTable("test-trip-table")
.withFileSystemViewConfig(new FileSystemViewStorageConfig.Builder()
+ .withRemoteServerPort(timelineServicePort)
.withEnableBackupForRemoteFileSystemView(false).build())
.withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(indexType).build())
.withClusteringConfig(clusteringConfig)
.withRollbackUsingMarkers(rollbackUsingMarkers);
}
+
+ protected int incrementTimelineServicePortToUse() {
Review comment:
but you can have ports be held by other processes within the system? Can
we try and obtain free ports like we do with HDFSTestService?
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java
##########
@@ -111,6 +112,8 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
+import scala.Tuple3;
Review comment:
anyway we can avoid this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
