xiarixiaoyao commented on a change in pull request #4060:
URL: https://github.com/apache/hudi/pull/4060#discussion_r757182187
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -389,15 +389,16 @@ private void
completeClustering(HoodieReplaceCommitMetadata metadata, JavaRDD<Wr
writeTableMetadata(table, metadata, new
HoodieInstant(HoodieInstant.State.INFLIGHT,
HoodieTimeline.REPLACE_COMMIT_ACTION, clusteringCommitTime));
finalizeWrite(table, clusteringCommitTime, writeStats);
try {
- // try to save statistics info to hudi
- if (config.isDataSkippingEnabled() &&
config.isLayoutOptimizationEnabled() &&
!config.getClusteringSortColumns().isEmpty()) {
- table.updateStatistics(context, writeStats, clusteringCommitTime,
true);
+ // Update outstanding metadata indexes
+ if (config.isLayoutOptimizationEnabled()
Review comment:
If you really want to modify it in this way, pls remove layout_
OPTIMIZE_ DATA_ SKIPPING_ Enable this configuration item.
This configuration item was introduced for fear of unstable data skippingļ¼
let's remove this config.
by the way, it is suggested to directly remove this judgment condition. In
this way, the cluster + sort operation can also generate indexes for query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
