codope commented on a change in pull request #4014:
URL: https://github.com/apache/hudi/pull/4014#discussion_r757232858
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -211,9 +219,10 @@ public boolean accept(Path path) {
} catch (TableNotFoundException e) {
// Non-hoodie path, accept it.
if (LOG.isDebugEnabled()) {
- LOG.debug(String.format("(1) Caching non-hoodie path under %s \n",
folder.toString()));
+ LOG.debug(String.format("(1) Caching non-hoodie path under %s and
%s \n", folder.toString(), baseDir.toString()));
Review comment:
`path under %s and %s` might confuse users. Maybe, `path under %s with
basePath %s` would be more clear
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -173,6 +173,13 @@ public boolean accept(Path path) {
}
if (baseDir != null) {
+ // Check whether baseDir in nonHoodiePathCache
+ if (nonHoodiePathCache.contains(baseDir.toString())) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Accepting non-hoodie path from cache: " + path);
+ }
+ return true;
+ }
Review comment:
We should check this for hoodie paths as well i.e. see if files under
`.hoodie` dir get accepted or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
