This is an automated email from the ASF dual-hosted git repository.

vinoth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 257a6a7  [HUDI-2856] Bit cask disk map delete modified (#4116)
257a6a7 is described below

commit 257a6a74569cdb500b06c53b92d05f6f5833aa31
Author: xuzifu666 <[email protected]>
AuthorDate: Sat Nov 27 07:11:01 2021 +0800

    [HUDI-2856] Bit cask disk map delete modified (#4116)
    
    * modified BitCaskDiskMap_close_function
    
    * change iterators location to finally
    
    * Update BitCaskDiskMap.java
---
 .../java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
index 289901d..7644afa 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
@@ -281,12 +281,12 @@ public final class BitCaskDiskMap<T extends Serializable, 
R extends Serializable
           }
         }
       }
-      writeOnlyFile.delete();
-      this.iterators.forEach(ClosableIterator::close);
     } catch (Exception e) {
       // delete the file for any sort of exception
-      writeOnlyFile.delete();
+      LOG.error("BitCaskDisMap close error ", e);
     } finally {
+      this.iterators.forEach(ClosableIterator::close);
+      writeOnlyFile.delete();
       super.close();
     }
   }

Reply via email to