prashantwason commented on a change in pull request #3865:
URL: https://github.com/apache/hudi/pull/3865#discussion_r758795588
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/LogReaderUtils.java
##########
@@ -27,24 +27,26 @@
import
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType;
import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.util.collection.Pair;
import org.apache.avro.Schema;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.Path;
import java.io.IOException;
import java.util.List;
+import java.util.Map;
import java.util.stream.Collectors;
/**
* Utils class for performing various log file reading operations.
*/
public class LogReaderUtils {
- private static Schema readSchemaFromLogFileInReverse(FileSystem fs,
HoodieActiveTimeline activeTimeline, Path path)
+ private static Schema readSchemaFromLogFileInReverse(FileSystem fs,
HoodieActiveTimeline activeTimeline, HoodieLogFile hoodieLogFile)
throws IOException {
- Reader reader = HoodieLogFormat.newReader(fs, new HoodieLogFile(path),
null, true, true);
+ // set length for the HoodieLogFile as it will be leveraged by
HoodieLogFormat.Reader with reverseReading enabled
Review comment:
where is this length being set? Or is this a stale comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
