yihua commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r759775742
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -128,14 +127,19 @@ public void addPropsFromFile(Path filePath) {
filePath.toString(),
Option.ofNullable(hadoopConfig).orElseGet(Configuration::new)
);
+ try {
+ if (isDefaultDirectory && !fs.exists(filePath)) {
Review comment:
I think we still need to check if the props file exists if the user
configures it. It doesn't have to be an error if the file cannot be found.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -119,7 +118,7 @@ public static void clearGlobalProps() {
*
* @param filePath File path for configuration file
*/
- public void addPropsFromFile(Path filePath) {
+ public void addPropsFromFile(Path filePath, boolean isDefaultDirectory) {
Review comment:
+1. `visitedFilePaths` also stores the loaded props file so each props
file is only read once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
