boneanxs commented on a change in pull request #4014:
URL: https://github.com/apache/hudi/pull/4014#discussion_r760148712
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -173,6 +173,13 @@ public boolean accept(Path path) {
}
if (baseDir != null) {
+ // Check whether baseDir in nonHoodiePathCache
+ if (nonHoodiePathCache.contains(baseDir.toString())) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Accepting non-hoodie path from cache: " + path);
+ }
+ return true;
+ }
Review comment:
Oh, I finally get your point, `.hoodie` dir get accepted or not is
checked by test `testHoodiePaths`
```java
assertFalse(pathFilter.accept(new Path("file:///" + basePath + "/" +
HoodieTableMetaClient.METAFOLDER_NAME + "/")));
assertFalse(pathFilter.accept(new Path("file:///" + basePath + "/" +
HoodieTableMetaClient.METAFOLDER_NAME)));
```
Also add files under `.hoodie` check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
