manojpec opened a new pull request #4185:
URL: https://github.com/apache/hudi/pull/4185
## What is the purpose of the pull request
- Fetching partition files or all partitions from the metadata table is
failing
when run over S3. Metadata table uses HFile format for the base files and
the
record lookup uses HFile.Reader and HFileScanner interfaces to get
records by
partition keys. When the backing storage is S3, this record lookup from
HFiles
is failing with IOException, in turn failing the caller commit/update
operations.
## Brief change log
- Metadata table looks up HFile records with positional read enabled so as
to
perform better for random lookups. But this positional read key lookup is
returning with partial read sizes over S3 leading to HFile scanner
throwing
IOException. This doesn't happen over HDFS. Metadata table though uses
the HFile
for random key lookups, the positional read is not mandatory as we sort
the keys
when doing a lookup for multiple keys.
- The fix is to disable HFile positional read for all HFile scanner based
key lookups.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test
coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
