manojpec commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761333253



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileWriter.java
##########
@@ -104,9 +106,13 @@ public HoodieHFileWriter(String instantTime, Path file, 
HoodieHFileConfig hfileC
 
   @Override
   public void writeAvroWithMetadata(R avroRecord, HoodieRecord record) throws 
IOException {
-    prepRecordWithMetadata(avroRecord, record, instantTime,
-        taskContextSupplier.getPartitionIdSupplier().get(), recordIndex, 
file.getName());
-    writeAvro(record.getRecordKey(), (IndexedRecord) avroRecord);
+    if (populateMetaFields) {

Review comment:
       Is this change backward compatible. On disk format of metadata records 
are now going to miss out on the meta fields. After the downgrade would this 
break anything?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to