nsivabalan commented on pull request #4201: URL: https://github.com/apache/hudi/pull/4201#issuecomment-985508006
I get the intention behind the original fix. But I am most concerned that, for the same record (non-row writer path) in 0.9.0, and 0.10.0, we might return diff key gen values and hence, an update could be mis-interpreted as an insert which is a def no. We wanted to fix the inconsistency, but not in this way. Let's take this up immediately after the release. I had a quick chat with sagar on the proposed fix(if not for reverting), there could be some more gaps in the fix we are proposing. so, better to just revert it for now and take a detailed look at all key gens across row writer and non-row writer and fix them altogether in next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
