[hudi] branch master updated: [HUDI-2934] Optimize RequestHandler code style

[danny0405]

This is an automated email from the ASF dual-hosted git repository.

danny0405 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 568181a  [HUDI-2934] Optimize RequestHandler code style
568181a is described below

commit 568181a3e7c1d43a4ee8573d3746600be4f94379
Author: fengli <ldliu...@163.com>
AuthorDate: Sat Dec 4 13:56:25 2021 +0800

    [HUDI-2934] Optimize RequestHandler code style
    
    close apache/hudi#4215
---
 .../main/java/org/apache/hudi/hive/SchemaDifference.java   |  1 -
 .../org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java    |  5 +++--
 .../org/apache/hudi/timeline/service/RequestHandler.java   | 14 +++++++-------
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
index e207b85..f48208a 100644
--- 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
+++ 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
@@ -28,7 +28,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.StringJoiner;
 
-
 /**
  * Represents the schema difference between the storage schema and hive table 
schema.
  */
diff --git 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
index 6fbcfa9..aed2bbe 100644
--- 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
+++ 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
@@ -39,8 +39,9 @@ import java.util.List;
 import java.util.Map;
 
 import static org.apache.hudi.hive.util.HiveSchemaUtil.HIVE_ESCAPE_CHARACTER;
-/*
-This class adds functionality for all query based DDLExecutors. The classes 
extending it only have to provide runSQL(sql) functions.
+
+/**
+ * This class adds functionality for all query based DDLExecutors. The classes 
extending it only have to provide runSQL(sql) functions.
  */
 public abstract class QueryBasedDDLExecutor implements DDLExecutor {
   private static final Logger LOG = 
LogManager.getLogger(QueryBasedDDLExecutor.class);
diff --git 
a/hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
 
b/hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
index c4edc18..4744fbb 100644
--- 
a/hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
+++ 
b/hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
@@ -500,14 +500,14 @@ public class RequestHandler {
 
         if (refreshCheck) {
           long beginFinalCheck = System.currentTimeMillis();
-          String errMsg =
-              "Last known instant from client was "
-                  + 
context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
-                      HoodieTimeline.INVALID_INSTANT_TS)
-                  + " but server has the following timeline "
-                  + 
viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM))
-                      
.getTimeline().getInstants().collect(Collectors.toList());
           if (isLocalViewBehind(context)) {
+            String errMsg =
+                "Last known instant from client was "
+                    + 
context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
+                        HoodieTimeline.INVALID_INSTANT_TS)
+                    + " but server has the following timeline "
+                    + 
viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM))
+                        
.getTimeline().getInstants().collect(Collectors.toList());
             throw new BadRequestResponse(errMsg);
           }
           long endFinalCheck = System.currentTimeMillis();