This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch release-0.10.0 in repository https://gitbox.apache.org/repos/asf/hudi.git
commit c38ebbc2353fccf9ca91b21307d316bae27e9074 Author: Y Ethan Guo <[email protected]> AuthorDate: Tue Nov 30 06:45:50 2021 -0800 [HUDI-2891] Fix write configs for Java engine in Kafka Connect Sink (#4161) (cherry picked from commit ea009b55a385564f76beb99468f363edd3c4828a) --- hudi-kafka-connect/demo/config-sink-hive.json | 1 - hudi-kafka-connect/demo/config-sink.json | 1 - .../org/apache/hudi/connect/writers/KafkaConnectWriterProvider.java | 2 ++ .../test/java/org/apache/hudi/writers/TestBufferedConnectWriter.java | 2 ++ 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hudi-kafka-connect/demo/config-sink-hive.json b/hudi-kafka-connect/demo/config-sink-hive.json index bf7e998..214fd18 100644 --- a/hudi-kafka-connect/demo/config-sink-hive.json +++ b/hudi-kafka-connect/demo/config-sink-hive.json @@ -10,7 +10,6 @@ "topics": "hudi-test-topic", "hoodie.table.name": "hudi-test-topic", "hoodie.table.type": "MERGE_ON_READ", - "hoodie.metadata.enable": "false", "hoodie.base.path": "hdfs://namenode:8020/user/hive/warehouse/hudi-test-topic", "hoodie.datasource.write.recordkey.field": "volume", "hoodie.datasource.write.partitionpath.field": "date", diff --git a/hudi-kafka-connect/demo/config-sink.json b/hudi-kafka-connect/demo/config-sink.json index 9d1aedf..105c4d4 100644 --- a/hudi-kafka-connect/demo/config-sink.json +++ b/hudi-kafka-connect/demo/config-sink.json @@ -10,7 +10,6 @@ "topics": "hudi-test-topic", "hoodie.table.name": "hudi-test-topic", "hoodie.table.type": "MERGE_ON_READ", - "hoodie.metadata.enable": "false", "hoodie.base.path": "file:///tmp/hoodie/hudi-test-topic", "hoodie.datasource.write.recordkey.field": "volume", "hoodie.datasource.write.partitionpath.field": "date", diff --git a/hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectWriterProvider.java b/hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectWriterProvider.java index 18c1835..5bac1f0 100644 --- a/hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectWriterProvider.java +++ b/hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectWriterProvider.java @@ -22,6 +22,7 @@ import org.apache.hudi.client.HoodieJavaWriteClient; import org.apache.hudi.client.WriteStatus; import org.apache.hudi.client.common.HoodieJavaEngineContext; import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.engine.EngineType; import org.apache.hudi.common.engine.HoodieEngineContext; import org.apache.hudi.common.model.HoodieAvroPayload; import org.apache.hudi.common.util.ReflectionUtils; @@ -74,6 +75,7 @@ public class KafkaConnectWriterProvider implements ConnectWriterProvider<WriteSt // Create the write client to write some records in writeConfig = HoodieWriteConfig.newBuilder() + .withEngineType(EngineType.JAVA) .withProperties(connectConfigs.getProps()) .withFileIdPrefixProviderClassName(KafkaConnectFileIdPrefixProvider.class.getName()) .withProps(Collections.singletonMap( diff --git a/hudi-kafka-connect/src/test/java/org/apache/hudi/writers/TestBufferedConnectWriter.java b/hudi-kafka-connect/src/test/java/org/apache/hudi/writers/TestBufferedConnectWriter.java index b0dcf38..458c79a 100644 --- a/hudi-kafka-connect/src/test/java/org/apache/hudi/writers/TestBufferedConnectWriter.java +++ b/hudi-kafka-connect/src/test/java/org/apache/hudi/writers/TestBufferedConnectWriter.java @@ -20,6 +20,7 @@ package org.apache.hudi.writers; import org.apache.hudi.client.HoodieJavaWriteClient; import org.apache.hudi.client.common.HoodieJavaEngineContext; +import org.apache.hudi.common.engine.EngineType; import org.apache.hudi.common.model.HoodieRecord; import org.apache.hudi.common.testutils.HoodieTestDataGenerator; import org.apache.hudi.common.util.Option; @@ -62,6 +63,7 @@ public class TestBufferedConnectWriter { configs = KafkaConnectConfigs.newBuilder().build(); schemaProvider = new TestAbstractConnectWriter.TestSchemaProvider(); writeConfig = HoodieWriteConfig.newBuilder() + .withEngineType(EngineType.JAVA) .withPath("/tmp") .withSchema(schemaProvider.getSourceSchema().toString()) .build();
