leesf commented on a change in pull request #4193:
URL: https://github.com/apache/hudi/pull/4193#discussion_r763011045
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala
##########
@@ -208,7 +208,7 @@ object InsertIntoHoodieTableCommand extends Logging {
val options = hoodieCatalogTable.catalogProperties ++
tableConfig.getProps.asScala.toMap ++ extraOptions
val parameters = withSparkConf(sparkSession, options)()
- val preCombineColumn = hoodieCatalogTable.preCombineKey.getOrElse("")
+ val preCombineColumn = hoodieCatalogTable.preCombineKey.getOrElse("ts")
Review comment:
please use default value instead of hardcoded ts
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
##########
@@ -89,7 +89,7 @@ case class UpdateHoodieTableCommand(updateTable: UpdateTable)
extends RunnableCo
val catalogProperties = hoodieCatalogTable.catalogProperties
val tableConfig = hoodieCatalogTable.tableConfig
- val preCombineColumn = Option(tableConfig.getPreCombineField).getOrElse("")
+ val preCombineColumn =
Option(tableConfig.getPreCombineField).getOrElse("ts")
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
