yihua commented on a change in pull request #4255:
URL: https://github.com/apache/hudi/pull/4255#discussion_r765181472



##########
File path: README.md
##########
@@ -149,6 +149,30 @@ You can update multiple docs versions at the same time 
because each directory in
 
 Example: When you change any file in `versioned_docs/version-0.7.0/`, it will 
only affect the docs for version `0.7.0`.
 
+## Configs
+Configs can be automatically updated by following these steps.
+
+Execute these from hudi-utils dir <br/>
+Ensure you have hudi artifacts from latest master has been installed in your 
local maven repo before proceeding. <br/>
+If not execute `mvn install -DskipTests` in your hudi repo  <br/>

Review comment:
       `If not execute`
   -> `If not, execute`

##########
File path: README.md
##########
@@ -149,6 +149,30 @@ You can update multiple docs versions at the same time 
because each directory in
 
 Example: When you change any file in `versioned_docs/version-0.7.0/`, it will 
only affect the docs for version `0.7.0`.
 
+## Configs
+Configs can be automatically updated by following these steps.
+
+Execute these from hudi-utils dir <br/>
+Ensure you have hudi artifacts from latest master has been installed in your 
local maven repo before proceeding. <br/>
+If not execute `mvn install -DskipTests` in your hudi repo  <br/>
+
+```shell
+mvn clean
+mvn install
+```
+Set the appropriate SNAPSHOT version and execute the below commands
+```shell
+VERSION=0.11.0
+```
+
+```shell
+java -cp 
target/hudi-utils-1.0-SNAPSHOT-jar-with-dependencies.jar:$HOME/.m2/repository/org/apache/hudi/hudi-utilities-bundle_2.11/$VERSION-SNAPSHOT/hudi-utilities-bundle_2.11-$VERSION-SNAPSHOT.jar:$HOME/.m2/repository/org/apache/hudi/hudi-spark-bundle_2.11/$VERSION-SNAPSHOT/hudi-spark-bundle_2.11-$VERSION-SNAPSHOT.jar:$HOME/.m2/repository/org/apache/hudi/hudi-flink-bundle_2.11/$VERSION-SNAPSHOT/hudi-flink-bundle_2.11-$VERSION-SNAPSHOT.jar:$HOME/.m2/repository/org/apache/hudi/hudi-kafka-connect-bundle/$VERSION-SNAPSHOT/hudi-kafka-connect-bundle-$VERSION-SNAPSHOT.jar
 org.apache.hudi.utils.HoodieConfigDocGenerator

Review comment:
       `hudi-utils-1.0-SNAPSHOT-jar-with-dependencies.jar`
   -> is the version `1.0-SNAPSHOT` or `0.11.0-SNAPSHOT`?

##########
File path: README.md
##########
@@ -149,6 +149,30 @@ You can update multiple docs versions at the same time 
because each directory in
 
 Example: When you change any file in `versioned_docs/version-0.7.0/`, it will 
only affect the docs for version `0.7.0`.
 
+## Configs
+Configs can be automatically updated by following these steps.
+
+Execute these from hudi-utils dir <br/>
+Ensure you have hudi artifacts from latest master has been installed in your 
local maven repo before proceeding. <br/>

Review comment:
       `Ensure you have hudi artifacts from latest master has been installed`
   -> `Ensure you have hudi artifacts from latest master installed`

##########
File path: hudi-utils/README.md
##########
@@ -15,9 +15,21 @@
   limitations under the License.
 -->
 
+Execute these from hudi-utils dir <br/>
+Ensure you have hudi artifacts from latest master has been installed in your 
local maven repo before proceeding. <br/> 
+If not execute `mvn install -DskipTests` in your hudi repo  <br/>

Review comment:
       Same here. Looks like these are repeated docs though.

##########
File path: README.md
##########
@@ -149,6 +149,30 @@ You can update multiple docs versions at the same time 
because each directory in
 
 Example: When you change any file in `versioned_docs/version-0.7.0/`, it will 
only affect the docs for version `0.7.0`.
 
+## Configs

Review comment:
       Instead of copying the docs, maybe better to provide a link to the 
`hudi-utils/README.md` in this section?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to